Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: a3fecb78bd20
Choose a base ref
...
head repository: jruby/jruby
compare: e4d16ac8afc3
Choose a head ref
  • 9 commits
  • 15 files changed
  • 1 contributor

Commits on Dec 17, 2014

  1. Re-apply

    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    7c0595b View commit details
    Browse the repository at this point in the history

  2. No reason for module or class body to try and receive an implicit blo… 

    …ck arg
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    06ad06f View commit details
    Browse the repository at this point in the history

  3. evalSimple path no longer has duplicated scope (messiness to be clean… 

    …ed up after evalWithBinding

removes its additionalScope).
Reinstated NoVars assertion because we no longer erroneously ask 'phantom' scope for a block
value which is never there...ooooooo spooky
SClasses should not need to get closure
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    73df3d2 View commit details
    Browse the repository at this point in the history

  4. Still a bit messy but all extra scope removal is done with known extr… 

    …a depth calcs removed
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    4fccdd4 View commit details
    Browse the repository at this point in the history

  5. Still a bit messy but all extra scope removal is done with known extr… 

    …a depth calcs removed
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    695baa1 View commit details
    Browse the repository at this point in the history

  6. Some random cleanup converging towards a stopping point

    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    e8b9780 View commit details
    Browse the repository at this point in the history

  7. End of eval changes for now. Later this will be revisted once we swit… 

    …ch to only using StaticScope for lvars
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    8e70622 View commit details
    Browse the repository at this point in the history

  8. Fix #2301

    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    b5b7305 View commit details
    Browse the repository at this point in the history

  9. I see no reason for setting parent frame visibility to public. Nothin… 

    …g triggered so removing
    @enebo
    enebo committed Dec 17, 2014
    Copy the full SHA
    e4d16ac View commit details
    Browse the repository at this point in the history