Console Script & Renaming API #92
Conversation
|
|
1 similar comment
|
|
| @@ -213,9 +213,11 @@ def set_composite_mode(self, mode): | |||
| """ | |||
| self.establish_connection() | |||
| # only modes from 0 to 3 are supported | |||
| if mode >= 0 and mode <= 3: | |||
| mode_map = {'NONE': 0, 'PIP': 1, 'DUAL_PREVIEW': 2, 'DUAL_EQUAL': 3} | |||
There was a problem hiding this comment.
Maybe these should be constants on the controller class? IE
class Blah:
COMPOSITE_NONE = []
COMPOSITE_PIP = []
def to_number(self, mode):
return {self.COMPOSITE_PIP: 1, ...}[mode]
|
Can you split this into two pull requests? |
|
|
|
|
|
|
|
|
|
|
| @@ -293,7 +303,8 @@ def adjust_pip(self, xpos, ypos, width, height): | |||
| def switch(self, channel, port): | |||
| """Switch the channel to the target port | |||
| :param channel: The channel to be switched, 'A', 'B', 'a' | |||
| :param channel: The channel to be switched: | |||
There was a problem hiding this comment.
These should be "VIDEO_A", "VIDEO_B" and "AUDIO" now right?
|
|
|
@hyades Where are we at with finish this off? We split a bunch of it out right? |
|
Closing this pull request in preference for #121 |
No description provided.