RESTWS-429: Update OrderResource to match the most recent changes in 1.10 #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,6 +195,7 @@ | |||
| <order_type order_type_id="14" name="X-Ray Sheet order" parent="12" java_class_name="org.openmrs.XRaySheetRadiologyOrder" description="Sample radiology sheetorder" creator="1" date_created="2008-08-15 15:49:04.0" retired="false" uuid="e83a5d30-ae07-11e3-a5e2-0800200c9a66"/> | |||
| <order_type order_type_id="15" name="Theater Order" java_class_name="org.openmrs.TheaterOrder" description="Some theater order" creator="1" date_created="2008-08-15 13:50:14.0" retired="false" uuid="bf7f3ab0-ae06-11e3-a5e2-0800200c9a66"/> | |||
| <order_type order_type_id="16" name="Lab Order" java_class_name="org.openmrs.LabOrder" description="Some lab order" creator="1" date_created="2008-08-15 15:49:04.0" retire_reason="None" retired="true" retired_by="1" date_retired="2008-08-15 00:00:00.0" uuid="cc3fb1d0-ae06-11e3-a5e2-0800200c9a66"/> | |||
| <order_type_class_map order_type_id="1" concept_class_id="3"/> | |||
There was a problem hiding this comment.
What is the use of adding this? You can add it from the module's test data
There was a problem hiding this comment.
This is the dataset which is used by module's tests. I thought that it's better approach than adding additional file with just a single data entity. Moreover, it can come in handy with other 1.10.x tests using this dataset.
Actually, every order_type and concept_class should be linked like that according to the latest changes
There was a problem hiding this comment.
That's not correct, not every order type has to be linked and we intentionally left order_type 1 unlinked
|
@wluyima are we going to merge this? |
|
No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.