Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rb_funcall_with_block #3144

Merged

Conversation

seanchas116
Copy link
Contributor

This commit adds rb_funcall_with_block (which is available in MRI) to the C API.
rb_funcall_with_block is almost same as rb_funcall2b but does not call private methods.

This commit adds `rb_funcall_with_block` (which is available in MRI) to the C
API.
This commit adds specs for `rb_funcall_with_block`.
@seanchas116 seanchas116 changed the title Add rb funcall with block Add rb_funcall_with_block Sep 28, 2014
@@ -434,4 +434,23 @@ def method_private; :method_private end
lambda { @s.rb_funcall3(@obj, :method_private) }.should raise_error(NoMethodError, /private/)
end
end

describe 'rb_funcall_with_block' do

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty line isn't needed here.

@yorickpeterse yorickpeterse added the C-API Compatibility Function and feature compatibility with the MRI C-API label Sep 28, 2014
@seanchas116
Copy link
Contributor Author

@yorickpeterse Thank you for the comments!

@seanchas116
Copy link
Contributor Author

@yorickpeterse
Copy link
Contributor

Shit, I completely forgot about this. @seanchas116 is this good to go, or are you working on any further changes?

@seanchas116
Copy link
Contributor Author

Sorry for taking time. There is no further changes on this PR.

yorickpeterse pushed a commit that referenced this pull request Oct 3, 2014
@yorickpeterse yorickpeterse merged commit 6580094 into rubinius:master Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API Compatibility Function and feature compatibility with the MRI C-API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants