Raise NotImplementedError in String mutable meths

elia · elia · commit b1d0650e19ce · 2014-10-31T15:21:12.000+01:00
This is for improved usability, previously method_missing was called.
diff --git a/opal/corelib/string.rb b/opal/corelib/string.rb
@@ -70,6 +70,10 @@ def <=>(other)
     end
   end
 
+  def <<(other)
+    raise NotImplementedError, 'Mutable String methods are not supported in Opal.'
+  end
+
   def ==(other)
     return false unless String === other
 
@@ -147,6 +151,8 @@ def capitalize
     `self.charAt(0).toUpperCase() + self.substr(1).toLowerCase()`
   end
 
+  alias capitalize! <<
+
   def casecmp(other)
     other = Opal.coerce_to(other, String, :to_str).to_s
 
@@ -201,6 +207,8 @@ def chomp(separator = $/)
     self
   end
 
+  alias chomp! <<
+
   def chop
     %x{
       var length = self.length;
@@ -218,6 +226,8 @@ def chop
     }
   end
 
+  alias chop! <<
+
   def chr
     `self.charAt(0)`
   end
@@ -244,6 +254,8 @@ def downcase
     `self.toLowerCase()`
   end
 
+  alias downcase! <<
+
   def each_char(&block)
     return enum_for :each_char unless block_given?
 
@@ -318,6 +330,8 @@ def gsub(pattern, replace = undefined, &block)
     }
   end
 
+  alias gsub! <<
+
   def hash
     `self.toString()`
   end
@@ -454,6 +468,8 @@ def lstrip
     `self.replace(/^\s*/, '')`
   end
 
+  alias lstrip! <<
+
   def match(pattern, pos = undefined, &block)
     if String === pattern || pattern.respond_to?(:to_str)
       pattern = /#{Regexp.escape(pattern.to_str)}/
@@ -479,6 +495,8 @@ def next
     }
   end
 
+  alias next! <<
+
   def ord
     `self.charCodeAt(0)`
   end
@@ -496,6 +514,8 @@ def reverse
     `self.split('').reverse().join('')`
   end
 
+  alias reverse! <<
+
   # TODO handle case where search is regexp
   def rindex(search, offset = undefined)
     %x{
@@ -596,6 +616,7 @@ def scan(pattern, &block)
   alias size length
 
   alias slice []
+  alias slice! <<
 
   def split(pattern = $; || ' ', limit = undefined)
     %x{
@@ -744,6 +765,8 @@ def squeeze(*sets)
     }
   end
 
+  alias squeeze! <<
+
   def start_with?(*prefixes)
     %x{
       for (var i = 0, length = prefixes.length; i < length; i++) {
@@ -762,6 +785,8 @@ def strip
     `self.replace(/^\s*/, '').replace(/\s*$/, '')`
   end
 
+  alias strip! <<
+
   %x{
     // convert Ruby back reference to JavaScript back reference
     function convertReplace(replace) {
@@ -832,7 +857,10 @@ def sub(pattern, replace = undefined, &block)
     }
   end
 
+  alias sub! <<
+
   alias succ next
+  alias succ! <<
 
   def sum(n = 16)
     %x{
@@ -860,6 +888,8 @@ def swapcase
     }
   end
 
+  alias swapcase! <<
+
   def to_f
     %x{
       if (self.charAt(0) === '_') {
@@ -1043,6 +1073,8 @@ def tr(from, to)
     }
   end
 
+  alias tr! <<
+
   def tr_s(from, to)
     %x{
       if (from.length == 0) {
@@ -1196,10 +1228,14 @@ def tr_s(from, to)
     }
   end
 
+  alias tr_s! <<
+
   def upcase
     `self.toUpperCase()`
   end
 
+  alias upcase! <<
+
   def freeze
     self
   end
