Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliasing any jcr-namespaced properties to fedora: #669

Closed
wants to merge 2 commits into from
Closed

aliasing any jcr-namespaced properties to fedora: #669

wants to merge 2 commits into from

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Nov 25, 2014

https://www.pivotaltracker.com/n/projects/684825/stories/83411334

any jcr: properties are transformed to fedora: before sending to the JMS broker.

This potentially causes any jcr: property to populate the fedora: namespace, which may not be desired.

@@ -53,7 +53,7 @@ public FedoraEvent apply(final FedoraEvent evt) {
for (String property : evt.getProperties()) {
final String[] parts = property.split(":", 2);
if (parts.length == 2) {
final String prefix = parts[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have existing machinery for this? Can we use it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you have in mind, @cbeer?

@acoburn
Copy link
Contributor Author

acoburn commented Nov 26, 2014

any jcr: property now is checked in the RdfLexicon.jcrProperties set before being added to the event properties.

@acoburn
Copy link
Contributor Author

acoburn commented Mar 19, 2015

This is now tracked in JIRA: https://jira.duraspace.org/browse/FCREPO-1405

if ("jcr".equals(prefix)) {
if (jcrProperties.contains(createProperty(REPOSITORY_NAMESPACE + parts[1]))) {
event.addProperty(REPOSITORY_NAMESPACE + parts[1]);
} else if (LOGGER.isDebugEnabled()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the LOGGER.isDebugEnabled() guard.

@awoods
Copy link

awoods commented Mar 20, 2015

Resolved with: be0e046

@awoods awoods closed this Mar 20, 2015
@acoburn acoburn deleted the jms-jcr-properties branch July 29, 2015 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants