Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 4692b725deaf
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 54a9ec4ef09f
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 7, 2013

  1. stream_wrap: use getters, not direct field access 

    Hide member fields behind getters. Make the fields themselves const
in the sense that the pointer is non-assignable - the pointed to object
remains mutable.

Makes reasoning about lifecycle and mutability a little easier.
    @bnoordhuis
    bnoordhuis committed Aug 7, 2013
    Copy the full SHA
    da5ad92 View commit details
    Browse the repository at this point in the history

  2. stream_wrap: add handle type checkers 

    Add is_named_pipe(), is_named_pipe_ipc() and is_tcp() and update the
code base to use those rather than `stream->type == UV_FOO` and
`reinterpret_cast<uv_pipe_t*>(handle)->ipc` style checks.
    @bnoordhuis
    bnoordhuis committed Aug 7, 2013
    Copy the full SHA
    54a9ec4 View commit details
    Browse the repository at this point in the history