Use message/external-body MIME type for registering 'redirect' binaries #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
external-body
branch
3 times, most recently
from
6b73765
to
0e1a10e
Compare
| @@ -116,6 +117,7 @@ | |||
| public abstract class ContentExposingResource extends FedoraBaseResource { | |||
|
|
|||
| private static final Logger LOGGER = getLogger(ContentExposingResource.class); | |||
| public static final MediaType MESSAGE_EXTERNAL_BODY = MediaType.valueOf("message/external-body"); | |||
There was a problem hiding this comment.
I assume "message/external-body" is a completely fabricated mediatype. In which case, should it not be in either the "vendor tree" (vnd) or "personal tree" (prs)?
http://en.wikipedia.org/wiki/Internet_media_type#Vendor_tree
There was a problem hiding this comment.
No, it is not fabricated:
Plus, I don't think we abuse the MIME type too much: https://tools.ietf.org/html/rfc2017
awoods
pushed a commit
that referenced
this pull request
Oct 31, 2014
Use message/external-body MIME type for registering 'redirect' binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an idea for handling "redirect" binaries. I think it's a nice compromise between the empty-binary-with-a-special-property and creating a whole new type of thing.
Plus, I don't think we abuse the MIME type too much: https://tools.ietf.org/html/rfc2017
https://www.pivotaltracker.com/story/show/81770804