Adjusted change reactor primitive #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return all; | ||
| }, []); | ||
| // Case where you want a specified change | ||
| if(options) { |
There was a problem hiding this comment.
Minor style nitpicking: if (options)
|
LGTM. I see no problem with creating multiple reactor, this is cleaner. |
|
@mmalecki Word, merging. |
jcrugzz
added a commit
that referenced
this pull request
Mar 30, 2013
Adjusted change reactor primitive to be simpler and have clean api with {from: x, to: y} options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@indexzero based on our exchange in #4 i decided to just write a scenario since its easier to talk over code. It seems that the choices are sacrifice api cleanliness for multi key or sacrifice multi key. Thoughts?