dom/element: improve #inner_dom and add specs

opal · Feb 2, 2014 · a4bd2f3 · a4bd2f3
1 parent 8144d58
commit a4bd2f3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/opal/browser/dom/element.rb b/opal/browser/dom/element.rb
@@ -228,15 +228,19 @@ def id=(value)
   end
 
   def inner_dom(&block)
+    clear
+
     # FIXME: when block passing is fixed
     doc = document
-    clear; Builder.new(doc, self, &block)
+    Builder.new(doc, self, &block)
 
     self
   end
 
   def inner_dom=(node)
-    clear; self << node
+    clear
+
+    self << node
   end
 
   def /(*paths)

diff --git a/spec/dom/element_spec.rb b/spec/dom/element_spec.rb
@@ -68,6 +68,23 @@
     end
   end
 
+  describe '#inner_dom' do
+    html <<-HTML
+      <div id="lol">
+        <div id="wut"></div>
+      </div>
+    HTML
+
+    it 'builds the DOM and inserts it' do
+      $document["lol"].inner_dom {
+        div.omg!
+      }
+
+      expect($document["#lol #omg"]).to be_truthy
+      expect($document["#lol #wut"]).to be_falsy
+    end
+  end
+
   describe '#inspect' do
     it 'uses the node name' do
       el = $document.create_element('div')