Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 62c7fbcd2fc8
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 9b0e3db4f0e6
Choose a head ref
  • 19 commits
  • 104 files changed
  • 3 contributors

Commits on Dec 9, 2014

  1. build: do not generate support for libuv's probes

    Dtrace probes were removed from libuv recently, but their usage by node
    was not completely removed, causing build breaks on SmartOS.
    
    Even though the build is working on other platforms, these probes are
    not fired by libuv anymore, so there's no point in using them on these
    platforms too.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Julien Gilli committed Dec 9, 2014
    Copy the full SHA
    4dc660e View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2014

  1. deps: update libuv to 1.0.2

    PR-URL: #8847
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    saghul authored and trevnorris committed Dec 10, 2014
    Copy the full SHA
    20a7088 View commit details
    Browse the repository at this point in the history
  2. Add-on init: Dispatch signature on compile time

    Handle different init() signatures in a generic and type safe way. An adapter is selected at compile-time based on the signature of the init function. The adapter is stored in the module struct. At run-time the adapter unpacks the users init function and provides the requested arguments.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    0d40dd5 View commit details
    Browse the repository at this point in the history
  3. Consistency: renamed 'targets' to 'exports' in test add-ons

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    4c4577b View commit details
    Browse the repository at this point in the history
  4. Add-on init: There, cpplint fixed it.

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    92c529f View commit details
    Browse the repository at this point in the history
  5. Add-on init: Cleaned up internal module init

    Passing unused parameters isn't necessary any longer.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    3c52357 View commit details
    Browse the repository at this point in the history
  6. Add-on init: Fixed test add-ons

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    6b378a1 View commit details
    Browse the repository at this point in the history
  7. Add-on init: Added init signature test cases.

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    d75230b View commit details
    Browse the repository at this point in the history
  8. Add-on init: relinted

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    7e0ca1b View commit details
    Browse the repository at this point in the history
  9. Add-on init: polishing

    Cosmetics and corner case tests, like the void init function.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    8c7b7b2 View commit details
    Browse the repository at this point in the history
  10. Add-on init: Added C++11 variadic variant

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    47f4a84 View commit details
    Browse the repository at this point in the history
  11. Scrutiny: Build an add-on with C++11 enabled

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    be8ce5b View commit details
    Browse the repository at this point in the history
  12. Add-on init: relinted... again :-/

    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    74ec957 View commit details
    Browse the repository at this point in the history
  13. Add-on init: Simplified OptionalInitArg

    Replaced operator() with a plain static member function.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    84cfee7 View commit details
    Browse the repository at this point in the history
  14. Add-on init: Touch-ups

    Renamed struct field 'init' to 'nm_init'.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    19f5e23 View commit details
    Browse the repository at this point in the history
  15. Add-on init: Removed "private" argument

    The private argument is pretty useless since it is restricted to a compile-time constant. The only place to access this constant private value is the init function. This really makes no sense. Removing.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    44c9561 View commit details
    Browse the repository at this point in the history
  16. Revert "Add-on init: Removed "private" argument"

    This reverts commit dff8b1b.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    aafa3b6 View commit details
    Browse the repository at this point in the history
  17. Add-on init: Refactor after review by @indutny

    * do not attempt to inline registerAddon
    * removed C++11 variant
    * diff hygiene: respect line ownership in macros
    * cosmetics
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    47e4b97 View commit details
    Browse the repository at this point in the history
  18. Add-on init: Fix mess left after rebase

    Not sure how, but apparently I lost some changes in the rebase yesterday. Also not sure how I didn't notice. Anyway, this should do it.
    
    Reviewed-By: Test ReviewerName <test@reviewer.name>
    PR-URL: #8828
    agnat authored and orangemocha committed Dec 10, 2014
    Copy the full SHA
    9b0e3db View commit details
    Browse the repository at this point in the history