Comparing changes
Open a pull request
base repository: nodejs/node-v0.x-archive
base: 62c7fbcd2fc8
head repository: nodejs/node-v0.x-archive
compare: 9b0e3db4f0e6
- 19 commits
- 104 files changed
- 3 contributors
Commits on Dec 9, 2014
-
build: do not generate support for libuv's probes
Dtrace probes were removed from libuv recently, but their usage by node was not completely removed, causing build breaks on SmartOS. Even though the build is working on other platforms, these probes are not fired by libuv anymore, so there's no point in using them on these platforms too. Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Julien Gilli committedDec 9, 2014
Commits on Dec 10, 2014
-
PR-URL: #8847 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
-
Add-on init: Dispatch signature on compile time
Handle different init() signatures in a generic and type safe way. An adapter is selected at compile-time based on the signature of the init function. The adapter is stored in the module struct. At run-time the adapter unpacks the users init function and provides the requested arguments. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Consistency: renamed 'targets' to 'exports' in test add-ons
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: There, cpplint fixed it.
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Cleaned up internal module init
Passing unused parameters isn't necessary any longer. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Fixed test add-ons
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Added init signature test cases.
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Cosmetics and corner case tests, like the void init function. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Added C++11 variadic variant
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Scrutiny: Build an add-on with C++11 enabled
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: relinted... again :-/
Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Simplified OptionalInitArg
Replaced operator() with a plain static member function. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Renamed struct field 'init' to 'nm_init'. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Removed "private" argument
The private argument is pretty useless since it is restricted to a compile-time constant. The only place to access this constant private value is the init function. This really makes no sense. Removing. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
-
Add-on init: Refactor after review by @indutny
* do not attempt to inline registerAddon * removed C++11 variant * diff hygiene: respect line ownership in macros * cosmetics Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
-
Add-on init: Fix mess left after rebase
Not sure how, but apparently I lost some changes in the rebase yesterday. Also not sure how I didn't notice. Anyway, this should do it. Reviewed-By: Test ReviewerName <test@reviewer.name> PR-URL: #8828
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 62c7fbcd2fc8...9b0e3db4f0e6