TRUNK-2303: Fixed return of long decimal numbers to not use scientific n... #267
Conversation
|
See my comments from #266 About:
|
|
Did as you asked, i hope it looks fine regarding the formatting. |
|
Messed up commits, but fixed now. Also fixed one more comment |
| @@ -48,18 +50,16 @@ | |||
| * The {@link #getObsGroup()} method returns an optional parent. That parent object is also an Obs. | |||
| * The parent Obs object knows about its child objects through the {@link #getGroupMembers()} | |||
| * method. (Multi-level hierarchies are achieved by an Obs parent object being a member of another | |||
| * Obs (grand)parent object) Read up on the obs table: http://openmrs.org/wiki/Obs_Table_Primer | |||
| * Obs (grand)parent object) Read up on the obs table: http://openmrs.org/wiki/Obs_Table_Primer In | |||
There was a problem hiding this comment.
Can you wrap these in
tags so they don't get smushed together like this?
There was a problem hiding this comment.
what exactly do you mean?
There was a problem hiding this comment.
If you look at the diff you'll notice that javadoc that used to be separated by two newlines is now smushed together.
Autoformatting will do this if the javadoc doesn't have HTML tags to give some structure. So, add < p > tags around the paragraphs for this reason. (I see that in my prior comment it interpreted the p tag literally...)
|
Just updated commit, fixed javadoc using < p > tags. |
|
I'm not going to be able to code-review this before going on vacation, so maybe @wluyima can finish it off? |
TRUNK-2303: Fixed return of long decimal numbers to not use scientific n...
…enmrs#267) * Implemented naive file size checking * Fixed naming, their documentation is wrong * Should just skip install * Use npx lerna instead * Improved path * Removed artifact
...otation