Fix relationship_list_box() did not print value for [none], [any]

dregad · dregad · commit 42966e0196f4 · 2012-01-20T12:01:32.000+01:00
This caused e.g. a 'duplicate' relationship to be added when cloning a bug, even though '[none]' was selected in the list. This is a regression introduced by 93bbb36 Affects #12450
diff --git a/core/relationship_api.php b/core/relationship_api.php
@@ -809,12 +809,12 @@ function relationship_list_box( $p_default_rel_type = BUG_REL_ANY, $p_select_nam
 	?>
 <select name="<?php echo $p_select_name?>">
 <?php if( $p_include_any ) {?>
-<option value="<?php BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>
+<option value="<?php echo BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>
 <?php
 	}
 
 	if( $p_include_none ) {?>
-<option value="<?php BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>
+<option value="<?php echo BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>
 <?php
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -809,12 +809,12 @@ function relationship_list_box( $p_default_rel_type = BUG_REL_ANY, $p_select_nam`
`809`	`809`	`?>`
`810`	`810`	`<select name="<?php echo $p_select_name?>">`
`811`	`811`	`<?php if( $p_include_any ) {?>`
`812`		`-<option value="<?php BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>`
	`812`	`+<option value="<?php echo BUG_REL_ANY ?>" <?php echo( $p_default_rel_type == BUG_REL_ANY ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'any' )?>]</option>`
`813`	`813`	`<?php`
`814`	`814`	`}`
`815`	`815`
`816`	`816`	`if( $p_include_none ) {?>`
`817`		`-<option value="<?php BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>`
	`817`	`+<option value="<?php echo BUG_REL_NONE ?>" <?php echo( $p_default_rel_type == BUG_REL_NONE ? ' selected="selected"' : '' )?>>[<?php echo lang_get( 'none' )?>]</option>`
`818`	`818`	`<?php`
`819`	`819`	`}`
`820`	`820`