New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Updates II #558
Theme Updates II #558
Conversation
… / list structures Signed-off-by: Spuds <spuds@spudsdesign.com>
! General cleanup Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
! convert over to new drop menu markup Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Dont worry, I can fix that. Should also fix #543. Anyway if you like it, merge the sucker. Then I can start on the next lot. |
Found a few strays to go with this, if you feel like adding them. Otherwise, can go in the next lot. |
I'm really looking forward how it feels browsing around the forum with more of it. :) I'll update the site asap. At the code level, I think names that say what they are for, are a great plus. Please try to make the next PR by splitting some in variants. It will detach things nicely, and give us an idea on what the simple theme code is, at the disposal of us mortals to play with and customize. |
Eh, fixes. Don't get me started. The more I look inside the depths of this critter, the more I'm reminded of how much crud was in 2.0.x. 🤦 I just figured I could easily cut two dozen divs from the stats centre. Yes, that's right, 24 divs from one fairly simple page. Erk. Anyway, I'll try to start splitting some stuff out. Menus should be an obvious candidate. |
Apart from that, a fair bit of basic markup cleanup and some WAI-ARIA a11y tweaks. Divs where divs didn't need to be have been killed, with just nice clean ul's left. Name changes for better semantics. Large chunks of CSS have been moved around to try and get the ordering more sensible. Some other stuff.
Should address
#554
#550
#548
#517
Maybe some others