Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: 5ccd35406f38
Choose a base ref
...
head repository: cdk/cdk
compare: f934255f99d2
Choose a head ref
  • 10 commits
  • 62 files changed
  • 1 contributor

Commits on Aug 3, 2013

  1. Providing required delta for comparing floating points.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    fd2a0d8 View commit details
    Browse the repository at this point in the history
  2. Using 'hamcrest-all' for additional matchers.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    22c67dd View commit details
    Browse the repository at this point in the history
  3. hamcrest-all for eclipse users

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    1743627 View commit details
    Browse the repository at this point in the history
  4. Adding assertions to non-test and removing stdout.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    074a97f View commit details
    Browse the repository at this point in the history
  5. Adding back in test which were moved to SignatureTanimotoTest during …

    …module rearrangement.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    312035b View commit details
    Browse the repository at this point in the history
  6. The input header 'Marvin 07140515482D' is 2 characters longer than th…

    …e output header 'CDK 0803131301'. This shifts the index by two characters.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    60e22fe View commit details
    Browse the repository at this point in the history
  7. Revert "Fixing test regression that depended on the molecule having t…

    …he same kekule form - i.e. order dependant. When the ring perception changed the order may not be exactly the same but nothing should rely on that fact. Setting the aromaticity fixes the test failure.". This was actually a true failure, the pi-bonding movement tests for different kekule forms and the failure was correct.
    
    This reverts commit fdfbf5e.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    854389e View commit details
    Browse the repository at this point in the history
  8. Convenience method for matching in test

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    9436b8e View commit details
    Browse the repository at this point in the history
  9. Moving assertion to make it clearer what is going to change.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    c072851 View commit details
    Browse the repository at this point in the history
  10. Correcting test assertion. This reaction type generates two products …

    …(as there are two rings in the conjugated ring system). The new ring perception code perceives the two six member rings (used by the reaction) in a different order and so the output order of the products was switched. To avoid this happening again the matching was modified to check both combinations.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed Aug 3, 2013
    Copy the full SHA
    f934255 View commit details
    Browse the repository at this point in the history