Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enblig memory fences #2546

Merged
merged 1 commit into from Feb 1, 2015
Merged

Re-enblig memory fences #2546

merged 1 commit into from Feb 1, 2015

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Feb 1, 2015

It was breaking StampedVariableAccessor, resulting in
not sinchronized access to instance variables
when StampedVariableAccessor was used.

@pitr-ch
Re-enblig memory fences
10fc903 
It was breaking `StampedVariableAccessor`, resulting in
not sinchronized access to instance variables
when `StampedVariableAccessor` was used.
@headius
Copy link
Member

headius commented Feb 1, 2015

Thanks, @pitr-ch!

headius added a commit that referenced this pull request Feb 1, 2015
@headius
Merge pull request #2546 from pitr-ch/reenable-fences
47e3adc 
Re-enblig memory fences
@headius headius merged commit 47e3adc into jruby:master Feb 1, 2015
@headius
Copy link
Member

headius commented Feb 1, 2015

Very glad you found this before we shipped 9k final :-)

@pitr-ch
Copy link
Member Author

pitr-ch commented Feb 6, 2015

You are welcome, but it was pure luck anyway :)

@headius headius added this to the JRuby 9.0.0.0.pre2 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0.pre2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pitr-ch @headius