Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test #2030

Closed
wants to merge 1 commit into from
Closed

Missing test #2030

wants to merge 1 commit into from

Conversation

tduehr
Copy link
Contributor

@tduehr tduehr commented Oct 8, 2014

adds missing tests (and excludes for prepend) for current MRI inheritance behavior that are missing upstream.

prepend versions excluded for now
matches current MRI behavior
@headius
Copy link
Member

headius commented Nov 2, 2014

What's the status of this? Did we get these tests into MRI? If not, that's the right path...I can commit them if they're ready, and JRuby master is now running off trunk stdlib/tests so it will pick them up.

@tduehr
Copy link
Contributor Author

tduehr commented Nov 3, 2014

These were jruby only tests. I don't know if they've made it upstream yet. I also don't know why I didn't remove jruby's copy of the same tests with this commit. Mostly PR'd as a reference.

@headius
Copy link
Member

headius commented Nov 5, 2014

Ruby issue discussing the behavior and tests: https://bugs.ruby-lang.org/issues/10248

@headius headius added this to the JRuby 9000 milestone Nov 5, 2014
@tduehr
Copy link
Contributor Author

tduehr commented Nov 5, 2014

Clarification from Matz occurred on https://bugs.ruby-lang.org/issues/9112

@tduehr tduehr closed this Nov 14, 2014
@tduehr tduehr deleted the missing_test branch November 14, 2014 17:05
@tduehr tduehr restored the missing_test branch November 14, 2014 17:06
@tduehr tduehr reopened this Nov 14, 2014
@enebo enebo modified the milestone: JRuby 9.0.0.0 Jul 14, 2015
@kares
Copy link
Member

kares commented Jan 18, 2017

seems that this has been stale on MRI's end (for 2+ years): https://bugs.ruby-lang.org/issues/10248
this also now has merge conflicts. if MRI accepts these the tests will eventually reach JRuby as well ...
so I guess its safe to close (the bug can still link to the change-set since its refering to the fork-ed repo).

@kares kares closed this Jan 18, 2017
@kares kares added this to the Non-Release milestone Jan 18, 2017
@tduehr
Copy link
Contributor Author

tduehr commented Jan 18, 2017

I'll create a new one to put them in the jruby specific tests for now then.

@kares
Copy link
Member

kares commented Jan 18, 2017

@tduehr sounds very good esp. if they already pass, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants