Address the 1 critical issue from Sonar report. #699
Conversation
| @@ -137,4 +137,9 @@ public void addResponseHeaders(final HttpServletResponse servletResponse) { | |||
| public int compareTo(final PreferTag otherTag) { | |||
| return getTag().compareTo(otherTag.getTag()); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean equals(final Object obj) { | |||
There was a problem hiding this comment.
Please add a simple unit test for this method to: PreferTagTest.java
There was a problem hiding this comment.
Unit test added.
On Wed, Jan 28, 2015 at 2:59 PM, Andrew Woods notifications@github.com
wrote:
In
fcrepo-http-commons/src/main/java/org/fcrepo/http/commons/domain/PreferTag.java
#699 (comment):@@ -137,4 +137,9 @@ public void addResponseHeaders(final HttpServletResponse servletResponse) {
public int compareTo(final PreferTag otherTag) {
return getTag().compareTo(otherTag.getTag());
}
+
- @OverRide
- public boolean equals(final Object obj) {
Please add a simple unit test for this method to: PreferTagTest.java
—
Reply to this email directly or view it on GitHub
https://github.com/fcrepo4/fcrepo4/pull/699/files#r23717773.
Add unit test PreferTagTest.java Resolves: https://jira.duraspace.org/browse/FCREPO-1307 Add two unit tests and update PreferTag.java
| @@ -66,7 +68,13 @@ public PropertiesRdfContext(final FedoraResource resource, | |||
| private Iterator<Triple> triplesFromProperties(final FedoraResource n) | |||
| throws RepositoryException { | |||
| LOGGER.trace("Creating triples for node: {}", n); | |||
| final Iterator<Property> allProperties = n.getNode().getProperties(); | |||
| final Iterator<Property> allProperties; | |||
| if (n instanceof FedoraBinary) { | |||
There was a problem hiding this comment.
Why is PropertiesRdfContext in this PR?
There was a problem hiding this comment.
I didn't add this in this PR.. It shows in Untracked file.
I work 2 branches at the same time. I am sure that file didn't add into commit.
Override "equals(Object obj)" to comply with the contract of the "compareTo(T o)" method
Resolves: https://jira.duraspace.org/browse/FCREPO-1307