a few more small optimizations

mojolicious · Oct 30, 2013 · c6ddf11 · c6ddf11
1 parent 089936f
commit c6ddf11
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/lib/Mojo/Base.pm b/lib/Mojo/Base.pm
@@ -14,7 +14,6 @@ use IO::Handle ();
 sub import {
   my $class = shift;
   return unless my $flag = shift;
-  no strict 'refs';
 
   # Base
   if ($flag eq '-base') { $flag = $class }
@@ -31,6 +30,7 @@ sub import {
   # ISA
   if ($flag) {
     my $caller = caller;
+    no strict 'refs';
     push @{"${caller}::ISA"}, $flag;
     *{"${caller}::has"} = sub { attr($caller, @_) };
   }
@@ -54,7 +54,6 @@ sub attr {
   Carp::croak 'Default has to be a code reference or constant value'
     if ref $default && ref $default ne 'CODE';
 
-  # Compile attributes
   for my $attr (@{ref $attrs eq 'ARRAY' ? $attrs : [$attrs]}) {
     Carp::croak qq{Attribute "$attr" invalid} unless $attr =~ /^[a-zA-Z_]\w*$/;
 
@@ -81,8 +80,6 @@ sub attr {
     # Footer (return invocant)
     $code .= "  \$_[0];\n}";
 
-    # We compile custom attribute code for speed
-    no strict 'refs';
     warn "-- Attribute $attr in $class\n$code\n\n" if $ENV{MOJO_BASE_DEBUG};
     Carp::croak "Mojo::Base error: $@" unless eval "$code;1";
   }

diff --git a/lib/Mojo/Message.pm b/lib/Mojo/Message.pm
@@ -28,7 +28,7 @@ sub body {
   # Get
   return $content->asset->slurp unless @_;
 
-  # Set raw content
+  # Set
   $content->asset(Mojo::Asset::Memory->new->add_chunk(@_));
 
   return $self;

diff --git a/lib/Mojolicious/Lite.pm b/lib/Mojolicious/Lite.pm
@@ -20,17 +20,14 @@ sub import {
   my $caller = caller;
   no strict 'refs';
   push @{"${caller}::ISA"}, 'Mojo';
-  my $app = shift->new;
 
   # Generate moniker based on filename
   my $moniker = basename $ENV{MOJO_EXE};
   $moniker =~ s/\.(?:pl|pm|t)$//i;
-  $app->moniker($moniker);
+  my $app = shift->new(moniker => $moniker);
 
   # Initialize routes without namespaces
   my $routes = $app->routes->namespaces([]);
-
-  # Default static and template class
   $app->static->classes->[0] = $app->renderer->classes->[0] = $caller;
 
   # The Mojolicious::Lite DSL