Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default properties to pom.xml #705

Merged
merged 2 commits into from Feb 16, 2015
Merged

Add default properties to pom.xml #705

merged 2 commits into from Feb 16, 2015

Conversation

claussni
Copy link
Contributor

A couple of system properties are referenced throughout the POMs and code but never declared in any POM. These properties can be set in Maven command line executions: mvn ... -Dfcrepo.test.port=8080

The properties should be declared in the man POM using some default values. They can than be overridden by command line arguments.

@@ -59,6 +59,10 @@
<jacoco.out.it.file>jacoco-it.exec</jacoco.out.it.file>
<sonar.jacoco.reportPath>${jacoco.outputDir}/${jacoco.out.unit.file}</sonar.jacoco.reportPath>
<sonar.jacoco.itReportPath>${jacoco.outputDir}/${jacoco.out.it.file}</sonar.jacoco.itReportPath>
<!-- default properties that can be altered on the command line -->
<fcrepo.test.context.path/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there is a specific reason to include these two jacoco arg defaults, I would suggest leaving them out of the PR.
I am concerned that our Jenkins/Sonar reporting will become broken due to them.

The build-helper-maven-plugin is used to generate properties for dynamic
port configuration. This commit marks these properties with the word
`dynamic` to highlight that fact, e.g. `fcrepo.dynamic.test.port`.
awoods pushed a commit that referenced this pull request Feb 16, 2015
Add default properties to pom.xml
Partial resolution of: https://jira.duraspace.org/browse/FCREPO-1341
@awoods awoods merged commit 94b3b40 into fcrepo:master Feb 16, 2015
@claussni claussni deleted the fcrepo-1341 branch February 17, 2015 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants