Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

! Some basic css cleanup #319

Merged
merged 1 commit into from Apr 9, 2013
Merged

! Some basic css cleanup #319

merged 1 commit into from Apr 9, 2013

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Apr 9, 2013

These changes should not break anything, and if they do, then the markup behind the CSS needs to be fixed and not the css.

This change mostly targeted overqualified elements in the selectors which are bad for performance really. So things like div#bla should be #bla since its an ID there can only be one so whats with the div ... or img.sort should be .sort since what else is going to be in an image tag (and if class="sort" is used on non images, the markup should be fixed not the css to cover it up) ... or #footer_section ul li.copyright no need for the li since what else is inside of the ul that would have a class outside of the li .... stuff like that.

Anyway this was a branch I had left over when I was looking over the theme, use it if wanted, discard it otherwise ... just cleaning up my local dead branches

Signed-off-by: Spuds <spuds@spudsdesign.com>
norv added a commit that referenced this pull request Apr 9, 2013
@norv norv merged commit 99a0c21 into elkarte:master Apr 9, 2013
@Spuds Spuds deleted the themeadonna branch April 9, 2013 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants