Fixed a bug with local_variables ordering and duplicate variables #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebo
added a commit
that referenced
this pull request
Jan 27, 2015
Fixed a bug with local_variables ordering and duplicate variables
|
@Who828 Do you know if this is also a problem in earlier versions of Ruby? |
|
I filed the original bug, and I did not test anything but 9k. The bug was filed to capture an new spec failure when we last updated. In 1.7.18, it does look broken: |
|
@enebo So I'm not sure what to do here. This is a bug, MRI acknowledged it as a bug, but it was unfixed until 2.2. If we fix this on 1.7 branch, our local_variables behavior would not match 1.9.3. |
|
Then I think we leave it broken. That tells me no one likely has depended on this not being unique. I bet people who do this and care menually uniq the elements already. They definitely would if they want it to keep working between versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129 by removing the duplicate variables and matching the order across different scopes to MRI.