starting new workers early is too dangerous

mojolicious · Jan 30, 2015 · 92f9903 · 92f9903
1 parent b58d7ad
commit 92f9903
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/Changes b/Changes
@@ -5,8 +5,6 @@
     Mojo::Message.
   - Improved Hypnotoad load balancing by calling srand() after starting a new
     worker in Mojo::Server::Prefork.
-  - Improved Mojo::Server::Prefork to start a new worker as soon as and old
-    one signals that it is shutting down gracefully.
   - Fixed bug in Mojo::DOM::CSS where combinators needed to be surrounded by
     whitespace.
 

diff --git a/lib/Mojo/Server/Prefork.pm b/lib/Mojo/Server/Prefork.pm
@@ -107,8 +107,7 @@ sub _manage {
 
   # Spawn more workers if necessary and check PID file
   if (!$self->{finished}) {
-    $self->_spawn
-      while grep({ !$_->{graceful} } values %{$self->{pool}}) < $self->workers;
+    $self->_spawn while keys %{$self->{pool}} < $self->workers;
     $self->ensure_pid_file;
   }