New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t/27inline_maker.t fails on MS Windows #36
Comments
@bulk88, this is the infamous 27/7 failure again. Could you possibly look again at this to help figure out why this happens? |
I saw the same thing
There isn't much to say on why "diff" and "rm" aren't found on Win32. |
@kmx's said FAIL, because it did - yours said PASS. You can safely ignore all the diff/rm stuff, that's because the author of that code didn't write it portably. |
dmake handles { and } in a special manner, which means that $(INST_ARCHLIB) was never interpolated, but passed on as it is, which in turn broke the cleanup phase of Inline::C. They could be interpolated for dmake, and EUMM does that usually when generating, but it's less of a hassle to simply avoid them in the first place. Fixes ingydotnet/inline-c-pm#36
I just made a pull request to Inline.pm that should fix the root issue for this. A fix for this issue then would be a version dependency bump. As an explanation for how this came about: The Makefile code generation in Inline::MakeMaker made code that broke dmake in a subtle way, which caused the wrong path being handed to Inline::C cleanup, which then silently failed to remove the .packlist file, causing ExtUtils::Install to copy it over, mark read-only, and THEN to try and generate a new one. I'll also be making a pull request on Inline::C to ensure that it does not fail silently in the future, as well as one to ExtUtils::Install to see if they can at least warn when copying .packlist. Edit: PRs made, EU::Install ticket made: https://rt.cpan.org/Ticket/Display.html?id=102170 |
Since before 0.54 these strings were defined with single quotes, stopping the mod name from interpolating, and thus also the deletion of those files. related to ingydotnet#36 related to ingydotnet/inline-pm/51
Previously the cleanup phase just blindly tried to delete the files and silently gave up when it couldn't find them. With this change it'll check whether they exist and then delete them or die trying. I suspect it might also be useful to check whether $autodir is a directory and die if not, and to assume a .packlist is generated and die if it can't be found, but that's up to you guys. related to ingydotnet#36 related to ingydotnet/inline-pm/51
@ingydotnet : This should not be closed yet unless the dep version on Inline.pm has been bumped. ;) |
Bumped. Waiting on mohawk to review then will release Inline{,::C} together. |
Hi,
I have experienced the following failure on MS Windows (gcc-4.8.3)
Regards
kmx
The text was updated successfully, but these errors were encountered: