Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: foswiki/distro
base: a8356b846d5a
Choose a base ref
...
head repository: foswiki/distro
compare: 00cce6ba6536
Choose a head ref
  • 2 commits
  • 6 files changed
  • 1 contributor

Commits on Jan 30, 2015

  1. Item13220: An experiment in email flow

    Crawford, please revert if you don't like,  easier to do it this way
    than attaching patches.   Trying another flow for the email settings.
    
     - Move EnableEmail onto the Advanced settings panel.  The Wizard will
       control it.
     - Move Auto-config and Test email buttons up to WebMasterEmail.
     - Duplicate the Auto-config button onto the SMTP SERVER field
     - Add a checker for WebMasterEmail, and Remove the EnableEmail checker.
       The WebMasterEmail checker subclasses the EMAILADDRESS checker and
       provides more meaningful errors than the generic checker for a
       missing email address.
    
    I think that this gets the auto-config flow onto the first page and
    minimizes the chance of the user enabling email with an invalid
    configuration.
    
    One issue.  When the Wizard sets EnableEmail, it fails to trigger the
    re-check of WebMasterEmail, so there is a stuck warning.
    gac410 committed Jan 30, 2015
    Copy the full SHA
    29b5686 View commit details
    Browse the repository at this point in the history
  2. Item13220: Re-check FeatureAccess after password set

    There is a warning on the {FeatureAccess}{configure} that warns when the
    AdmingGroup is empty, and no admin password is set.  Re-check to clear
    the error when the password is set.
    gac410 committed Jan 30, 2015
    Copy the full SHA
    00cce6b View commit details
    Browse the repository at this point in the history