Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-3405 Automated Error Report: ModuleException: /var/lib/tomcat6/webapps/openmrs/WEB-INF/dwr-modules.xml file doesn't exist. #745

Closed
wants to merge 3 commits into from

Conversation

ujjwalarora
Copy link
Member

@ghost
Copy link

ghost commented Mar 9, 2014

@ujjwalarora - Please use both JIRA issue numbers AND a descriptive phrase in your pull requests AND commit comments, as described in https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section "Work on your task".

@ujjwalarora
Copy link
Member Author

The logic behind my solution is that whenever dwr-modules.xml file is not found, a script creates it using DOM before its used further in WebModuleUtil.java, and hence its very well recognized by the XML parser and new module information is written into it.

@ujjwalarora
Copy link
Member Author

Steps to Test :

1.) Delete the dwr-modules.xml from /webapps/openmrs/WEB-INF/dwr-modules.xml.
2.) Try to add/delete a module
3.) New dwr-modules.xml file would be created with the module info

@dkayiwa
Copy link
Member

dkayiwa commented Mar 10, 2014

@ujjwalarora can you add a unit test for this?
Secondly, can you always run "mvn clean install" before you commit to ensure that your changes are formatted according to our conventions?

@ujjwalarora
Copy link
Member Author

@dkayiwa Done. Added 2 unit tests such that they PASS in the edited file and FAIL in the previous configurations.
Yes, done 'mvn clean install'

Made a new pull request #789

@dkayiwa
Copy link
Member

dkayiwa commented Mar 18, 2014

Closing this because author made a new pull request.

@dkayiwa dkayiwa closed this Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants