Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 491ac6a84365
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 3b392d33c7c2
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 29, 2015

  1. Revert "url: support path for url.format" 

    This reverts commit d312b6d.

d312b6d introduced some confusion in
the existing API of url.format and url.parse.

The way the 'path' property overrides other properties in url.format's
input is too confusing for existing users compared to the issues it
fixes.

Fixes such as #9081 have been
proposed, but they do not make the API less confusing.

Instead, this change just reverts the original breaking change so that
it gives us more time after v0.12.0 is released to come up with a better
API for url.format, url.parse and other related APIs in the v0.13
development branch.

Fixes #9070.

Conflicts:
	doc/api/url.markdown

PR: #9109
PR-URL: #9109
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    Julien Gilli committed Jan 29, 2015
    Copy the full SHA
    3b392d3 View commit details
    Browse the repository at this point in the history