child_process: fix test implementation for options.detached

nodejs · Jun 11, 2012 · 2eb181d · 2eb181d
1 parent 25e8ea1
commit 2eb181d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 6 deletions.
diff --git a/test/fixtures/parent-process-nonpersistent.js b/test/fixtures/parent-process-nonpersistent.js
@@ -0,0 +1,13 @@
+
+var spawn = require('child_process').spawn,
+    path = require('path'),
+    childPath = path.join(__dirname, 'child-process-persistent.js');
+
+var child = spawn(process.execPath, [ childPath ], {
+  detached: true,
+  stdio: 'ignore'
+});
+
+console.log(child.pid);
+
+child.unref();
diff --git a/test/simple/test-child-process-detached.js b/test/simple/test-child-process-detached.js
@@ -24,15 +24,22 @@ var assert = require('assert');
 var path = require('path');
 
 var spawn = require('child_process').spawn;
-var childPath = path.join(__dirname, '..', 'fixtures', 'child-process-persistent.js');
+var childPath = path.join(__dirname, '..', 'fixtures', 'parent-process-nonpersistent.js');
+var persistentPid = -1;
 
-var child = spawn(process.execPath, [ childPath ], {
-  detached: true,
-  stdio: 'ignore'
+var child = spawn(process.execPath, [ childPath ]);
+
+child.stdout.on('data', function (data) {
+  persistentPid = parseInt(data, 10);
 });
 
 process.on('exit', function () {
-  process.kill(child.pid);
-  assert.throws(process.kill(child.pid), Error);
+  assert(persistentPid !== -1);
+  assert.throws(function () {
+    process.kill(child.pid);
+  });
+  assert.doesNotThrow(function () {
+    process.kill(persistentPid);
+  });
 });