Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 48e34515fa9d
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b80fcc52f61c
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 2, 2014

  1. Properly coerce to String in String#end_with?

    @meh
    meh committed Feb 2, 2014
    Copy the full SHA
    aea44e7 View commit details

  2. Properly coerce to String in String#start_with?

    @meh
    meh committed Feb 2, 2014
    Copy the full SHA
    5f0ed8b View commit details

  3. Fix String#end_with? in IE6..8 

    IE6..8 doesn't handle negative indices in String.prototype.substr
    @meh
    meh committed Feb 2, 2014
    Copy the full SHA
    b80fcc5 View commit details
Showing with 4 additions and 3 deletions.
  1. +4 −3 opal/corelib/string.rb
7 changes: 4 additions & 3 deletions opal/corelib/string.rb
View file
Original file line number Diff line number Diff line change
@@ -284,9 +284,10 @@ def empty?
def end_with?(*suffixes)
%x{
for (var i = 0, length = suffixes.length; i < length; i++) {
var suffix = #{Opal.coerce_to `suffixes[i]`, String, :to_str};
var suffix = #{Opal.coerce_to(`suffixes[i]`, String, :to_str).to_s};
if (self.length >= suffix.length && self.substr(0 - suffix.length) === suffix) {
if (self.length >= suffix.length &&
self.substr(self.length - suffix.length, suffix.length) == suffix) {
return true;
}
}
@@ -691,7 +692,7 @@ def squeeze(*sets)
def start_with?(*prefixes)
%x{
for (var i = 0, length = prefixes.length; i < length; i++) {
var prefix = #{Opal.coerce_to `prefixes[i]`, String, :to_str};
var prefix = #{Opal.coerce_to(`prefixes[i]`, String, :to_str).to_s};
if (self.indexOf(prefix) === 0) {
return true;