Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 7a66d8bb338f
Choose a base ref
...
head repository: jruby/jruby
compare: 824f063264de
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Dec 13, 2014

  1. Restructured encoding definition process a bit to allow easier extern… 

    …al use.
    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    1f88220 View commit details
    Browse the repository at this point in the history

  2. Tidied up the encoding visitor interfaces a bit.

    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    3beeeb8 View commit details
    Browse the repository at this point in the history

  3. [Truffle] Ensure the __ENCODING__ constant is set correctly.

    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    7e791ac View commit details
    Browse the repository at this point in the history

  4. [Truffle] Tag some newly failing language specs. 

    These started failing when we started setting __ENCODING__ correctly.  They were passing before due to happenstance.  After investigation, it looks like these only fail when passed through eval and likely due to source position tracking issues.
    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    70c8ce6 View commit details
    Browse the repository at this point in the history

  5. [Truffle] Tagged a new regexp encoding failure now that we're setting… 

    … __ENCODING__ properly.
    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    e0829ab View commit details
    Browse the repository at this point in the history

  6. [Truffle] New encoding implementation. 

    These changes mirror what JRuby is doing for the most part.  We have to track our own lists for now because EncodingService's lookup tables are specific to the non-Truffle JRuby class hierarchy.  These changes fix the ambiguous lookup problem the old implementation suffered from by using the encoding name, rather than the shared JCodings encoding object, as the lookup key.  All known encodings are now eagerly instantiated at startup.  This is in contrast to what non-Truffle JRuby does, whereby it defines its RubyEncoding instance but lazily loads the JCodings encoding object as needed.  Eagerly loading simplified some things, avoided some thread safety issues, and may be useful for other static analysis within Truffle.
    @nirvdrum
    nirvdrum committed Dec 13, 2014
    Copy the full SHA
    824f063 View commit details
    Browse the repository at this point in the history