New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create minted hierarchy for blank nodes #692
Conversation
@@ -104,6 +104,7 @@ | |||
|
|||
private static final Model m = createDefaultModel(); | |||
|
|||
private static final UUIDPathMinter pidMinter = new UUIDPathMinter(10,1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value here should probably be:
new UUIDPathMinter(2, 4);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default values should be, in any event, labelled constants.
private static void tagHierarchyWithPairtreeMixin(final Node baseNode, final Node createdNode) | ||
/** | ||
* | ||
* @param baseNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on reading these javadocs, I, as an API consumer, have no better understanding of what this method does.
Please add some detail.
Resolved with: b643547 |
https://jira.duraspace.org/browse/FCREPO-1258