Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 02374d0c178b
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: e235bce2ba39
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Feb 12, 2013

  1. Fix crypto.hmac behavior with empty keys. 

    node 0.9.6 introduced Buffer changes that cause the key argument of
Hmac::HmacInit (used in crypto.createHmac) to be NULL when the key is
empty. This argument is passed to OpenSSL's HMAC_Init, which does not
like NULL keys.

This change works around the issue by passing an empty string to
HMAC_Init when the key is empty, and adds crypto.createHmac tests for
the edge cases of empty keys and values.
    @pwnall @indutny
    pwnall authored and indutny committed Feb 12, 2013
    Copy the full SHA
    e235bce View commit details
    Browse the repository at this point in the history