Move methods from BasicObject to Object #2520
Merged
+30
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of debugging an unrelated issue, I came across an inconsistency between JRuby and CRuby: the
#itself
and#object_id
methods are defined onBasicObject
instead ofObject
.WARNING
I am not an expert ☕ programmer nor am I particularly familiar with the JRuby codebase, however I’ve made an attempt to fix this issue myself, as it appears to be mostly a ✂️ and 🍝 job.
I’ve also attempted to add a test to prevent this behavior from regressing, however I may have put it in the wrong place, as JRuby appears to have multiple test suites.
I’ve also taken the liberty to remove the
Object#id
method, which was deprecated when Ruby 1.9 was released and removed from CRuby before version 1.9 was released (search forrb_obj_id_obsolete
).