Added support for version reversion. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| final String objId = UUID.randomUUID().toString(); | ||
| final HttpPatch patch = new HttpPatch(serverAddress + objId + "/fcr:versions/invalid-version-label"); | ||
| execute(patch); | ||
| assertEquals(NOT_FOUND.getStatusCode(), getStatus(patch)); |
There was a problem hiding this comment.
Isn't this just getting a 404 because objId (presumably) doesn't exist?
There was a problem hiding this comment.
Yeah... missing a line in there to actually create the node. It seemed a little bit too convenient that this worked without additional code. I'll be submitting an update to the PR once I get this test corrected and then passing.
| assertNotNull(response); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
You may want to get into the pattern of using:
@test(expected = RuntimeException.class)
...instead of the pattern:
try{
...
fail()
} catch ()
}
|
Resolved with: 7df0138 Addresses: https://www.pivotaltracker.com/story/show/60883346 |
awoods
pushed a commit
that referenced
this pull request
Apr 10, 2014
Added support for version reversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.