Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDKException -> IllegalArgumentException in MolecularFormulaGenerator constructor #110

Closed
wants to merge 1 commit into from
Closed

CDKException -> IllegalArgumentException in MolecularFormulaGenerator constructor #110

wants to merge 1 commit into from

Conversation

tomas-pluskal
Copy link
Contributor

I changed the exception thrown in MolecularFormulaGenerator constructor when initial parameters are not set properly. I think IllegalArgumentException makes more sense and it is more convenient for users, because they don't need to specifically catch it.

@johnmay
Copy link
Member

johnmay commented Jan 5, 2015

Hi Tomas,

Removing the exception changes the signature and breaks compilation of down stream code. The compiler won't allow catching exceptions that aren't thrown.

I will pull this in since the class is relatively new but we're attempting to treat the public API is concrete as much as possible.

Thanks,
John

@tomas-pluskal
Copy link
Contributor Author

You are right, I should have committed this before you released v. 1.5.10.

@johnmay
Copy link
Member

johnmay commented Jan 5, 2015

Applied and pushed.

@johnmay johnmay closed this Jan 5, 2015
@tomas-pluskal
Copy link
Contributor Author

Why this pull request ends with "Closed with unmerged commits"?

@johnmay
Copy link
Member

johnmay commented Jan 7, 2015

Cherry picked rather than merged... Egon will be able to explain why is better but essentially it means you don't have a separate merge commit..

@tomas-pluskal
Copy link
Contributor Author

Thanks!
I noticed this pull request was pushed to johnmay/cdk but not to cdk/cdk. Is that on purpose or by accident?

@johnmay
Copy link
Member

johnmay commented Jan 8, 2015

Ah damn, accident...

@johnmay johnmay reopened this Jan 8, 2015
@johnmay
Copy link
Member

johnmay commented Jan 8, 2015

Correct now.

@johnmay johnmay closed this Jan 8, 2015
@tomas-pluskal tomas-pluskal deleted the formulagenerator branch January 9, 2015 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomas-pluskal @johnmay