Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling the pyliny precommit hook. #39

Merged
merged 1 commit into from Nov 26, 2014
Merged

Disabling the pyliny precommit hook. #39

merged 1 commit into from Nov 26, 2014

Conversation

mithro
Copy link
Member

@mithro mithro commented Nov 24, 2014

The precommit hook isn't smart enough to understand it should only run on
commits which are changing python files.

@mithro
Disabling the pyliny precommit hook.
cca3cdd 
The precommit hook isn't smart enough to understand it should only run on
commits which are changing python files.
@hyades
Copy link
Member

hyades commented Nov 26, 2014

We should fix this in future though.

hyades added a commit that referenced this pull request Nov 26, 2014
@hyades
Merge pull request #39 from mithro/disable-py-commit-hook
02c1a54 
Disabling the pyliny precommit hook.
@hyades hyades merged commit 02c1a54 into timvideos:master Nov 26, 2014
@mithro
Copy link
Member Author

mithro commented Nov 26, 2014

Yes, although precommit time is probably the wrong time to run.
On 27 Nov 2014 03:27, "Aayush Ahuja" notifications@github.com wrote:

Merged #39 #39.

—
Reply to this email directly or view it on GitHub
#39 (comment).

@mithro mithro deleted the disable-py-commit-hook branch November 28, 2014 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hyades hyades

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mithro @hyades