Update drafts JS to operate as a editor plugin #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spuds <spuds@spudsdesign.com>
…quick reply Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by:Spuds <spuds@spudsdesign.com>
…ith the header stripped :P Signed-off-by:Spuds <spuds@spudsdesign.com>
…tsJS Conflicts: themes/CurveClassic/Display.template.php themes/CurveClassic/GenericControls.template.php themes/default/Display.template.php Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
|
I think this is a much better idea, thank you for working on it! I admit I didn't test the PR, but it makes sense. Shall we try it? :) |
yep, merge please, I think it's better than before.. |
norv
added a commit
that referenced
this pull request
Jun 4, 2013
Update drafts JS to operate as a editor plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration
This splits the current drafts.js in to two files.
The first is the standard drafts.js which is only used by quick reply when it is not using the editor (e.g. a plain text box). This is a simplified version of the current draft.js.
The new file is drafts.plugin which loads with and is called directly by the editor. It uses the events as provided by the editor instead of trying to add new event handlers external to the editor. This should make the autosave better behaved.