Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
Process symlinked shared library as .node
Browse files Browse the repository at this point in the history
  • Loading branch information
paddybyers authored and isaacs committed Feb 1, 2012
1 parent 840229a commit 7e0bf7d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/module.js
Expand Up @@ -467,11 +467,11 @@ Module._extensions['.json'] = function(module, filename) {
};


//Native extension for .node
//Native extension for .node and OS-specific equivalents
Module._extensions['.node'] = function(module, filename) {
process.dlopen(filename, module.exports);
};

Module._extensions['.dylib'] = Module._extensions['.node'];

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Feb 1, 2012

Member

Shouldn't this check if process.platform === 'darwin'?

This comment has been minimized.

Copy link
@paddybyers

paddybyers Feb 1, 2012

Author

Yes it should


// bootstrap main module.
Module.runMain = function() {
Expand Down

3 comments on commit 7e0bf7d

@paddybyers
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In truth, I don't really think we need this any more, since we figured out how to get gyp to generate xcode projects to build with a .node extension. I'm happy to generate a PR that adds the condition you've suggested, or backs out the change.

@bnoordhuis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, Paddy. I'll back out the change.

@paddybyers
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. The other commit landed in the same PR is still good I think.

Please sign in to comment.