Added ability to listen on unix sockets #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -158,6 +173,11 @@ Client.prototype.connect = function (port, host, callback) { | |||
| callback(); | |||
| } | |||
| } | |||
| else if (this.type === 'unix') { | |||
| this.socket = new net.Socket({type: 'unix' }); | |||
| this.socket.setEncoding('utf8'); | |||
There was a problem hiding this comment.
Is there a reason to force this encoding type? http://nodejs.org/api/stream.html#stream_stream_setencoding_encoding
There was a problem hiding this comment.
might be a good chance to utilize options.encoding
There was a problem hiding this comment.
hmm I suppose not. I was just following what was done for TCP.
|
Thanks to a little help from @blakmatrix I got the tests working for the unix sockets. |
|
Cherry-picked. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #20. I have been working on the tests but I wanted to ask if there is a good way to test the unix socket case without creating more and more
unix.sockfiles in the directory. First time dealing with them. @mmalecki thoughts?