fixed memory leak in Mojo::UserAgent::Server

mojolicious · Apr 26, 2014 · 920fb56 · 920fb56
1 parent 85db3b1
commit 920fb56
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/Changes b/Changes
@@ -3,6 +3,7 @@
   - Improved Mojo::IOLoop::Delay with circular reference protection.
   - Improved Mojo::IOLoop::Delay to allow argument splicing.
   - Improved Mojo::IOLoop::Server to reuse cipher list from IO::Socket::SSL.
+  - Fixed memory leak in Mojo::UserAgent::Server.
 
 4.94  2014-04-20
   - Added reverse_proxy attribute to Mojo::Server::Daemon.

diff --git a/lib/Mojo/UserAgent/Server.pm b/lib/Mojo/UserAgent/Server.pm
@@ -3,6 +3,7 @@ use Mojo::Base -base;
 
 use Mojo::IOLoop;
 use Mojo::Server::Daemon;
+use Scalar::Util 'weaken';
 
 has ioloop => sub { Mojo::IOLoop->singleton };
 
@@ -36,6 +37,7 @@ sub _restart {
     ioloop => $self->ioloop,
     silent => 1
   );
+  weaken $server->{app};
   delete $self->{port} if $full;
   die "Couldn't find a free TCP port for application.\n"
     unless my $port = $self->{port} ||= Mojo::IOLoop->generate_port;