Adding new validation rules for orders and drugOrders. #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2488,14 +2488,14 @@ public void getAllConcepts_shouldExcludeRetiredConceptsWhenSetIncludeRetiredToFa | |||
| public void getAllConcepts_shouldOrderByAConceptField() throws Exception { | |||
| List<Concept> allConcepts = conceptService.getAllConcepts("dateCreated", true, true); | |||
|
|
|||
| assertEquals(29, allConcepts.size()); | |||
| assertEquals(30, allConcepts.size()); | |||
There was a problem hiding this comment.
The reason we make it possible to inject more data in a test method is to avoid adding more to the standard dataset which results in editing several existing tests like in this case, personally i only add extra data to standard test data if i know there is about 1-5 affected existing tests methods or if it's a new column or table.
| * @should fail validation if order concept is null | ||
| * @should fail validation if drug concept is different from order concept | ||
| * @should fail validation if dose, dose units, route, frequency are null for drugOrders with SIMPLE dosingType |
There was a problem hiding this comment.
Are you using https://wiki.openmrs.org/display/docs/Generate+Test+Case+Plugin
I see that this annotation has no matching test method and there are test methods with no matching @shoulds here
- Null check for careSetting, encounter, urgency, startDate, action field. - Null check for dose, dose units, route, frequency for drugOrders with SIMPLE dosingType - Null check for instructions for drugOrders with FREE_TEXT dosingType - Null check for dosing_instructions for drugOrders for any other dosingType. - Null check for quantity, quantity units, and number of refills for drugOrders with outpatient careSettings. Fixed tests failing due to these new validations. Fixed standardTestData.xml to create orders which honour these validations. Removing voiding of Orders & Obs from patient void handler. These are automatically voided in RequiredDataAdvice. Had to remove to fix some failing tests.
| * @should fail validation if quantityUnits is null for outpatient careSetting | ||
| * @should fail validation if quantity is null for outpatient careSetting | ||
| * @should fail validation if doseUnits is null when dose is present | ||
| * @should fail validation if quantityUnits is null when quantity is present |
There was a problem hiding this comment.
Looks like you missed durationUnits when duration is done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null check for careSetting, encounter, urgency, startDate, action field.
Fixed tests failing due to these new validations. Fixed standardTestData.xml to create orders which honour these validations.
Removing voiding of Orders & Obs from patient void handler.
These are automatically voided in RequiredDataAdvice. Had to remove to fix some failing tests.