This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
v8: fix postmortem metadata generation
The v8 team did some replumbing to the way maps link up to transitions and object descriptors. This patch fixes the build, but in the future we'll probably have to add some new fields.
- Loading branch information
e72ac8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davepacheco @bcantrill
You probably want to take a look and figure out what fields you need added to keep the ustack helper working.
e72ac8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a patch that both corrects gen-postmortem-metadata.py and adds tests for both the postmortem and DTrace support:
e72ac8a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcantrill
Thanks, landed in cc1b09d and 017009f. I can't send the v8 patch upstream now because it doesn't work with v8 trunk; you should probably take a look again after the dust has settled in v8.