TRUNK-4150 Added service to revise an order #630
Conversation
| @@ -59,6 +59,18 @@ | |||
| public Order saveOrder(Order order) throws APIException; | |||
|
|
|||
| /** | |||
| * Save or update the given <code>order</code> in the database | |||
| * | |||
| * @param order the Order to revise | |||
There was a problem hiding this comment.
This should be the new REVISE order not the order you are revising
There was a problem hiding this comment.
This should say the revised order
|
Implemented the feedback from last night's call. Please let us know what you think. |
| } | ||
|
|
||
| /** | ||
| * Make necessary checks, set necessary fields for discontinuing <code>orderToDiscontinue</code> |
There was a problem hiding this comment.
These javadocs seem incorrect, by the way i think you can call markAsDiscontinued instead of adding this method
|
@wluyima Implemented pretty much all the feedback. The only task remaining is pending on the decision if saveRevisedOrder should be included in saveOrder. |
| * @since 1.10 | ||
| * @should return all the order frequencies | ||
| */ | ||
| public List<OrderFrequency> getOrderFrequencies(); |
There was a problem hiding this comment.
Why is this in this pull request, this ticket says revise order, fetching order frequencies is a separate task if its own that belongs to another ticket that revising an order doesn't depend on
No description provided.