Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejitsu/nodejitsu-api
base: fbf548331f4f^
Choose a base ref
...
head repository: nodejitsu/nodejitsu-api
compare: 92aef4efdd77
Choose a head ref
  • 4 commits
  • 10 files changed
  • 1 contributor

Commits on Jan 7, 2013

  1. [dep] Bump dependencies to the latest version

    [minor] Added missing keywords
    3rd-Eden committed Jan 7, 2013
    Copy the full SHA
    fbf5483 View commit details
    Browse the repository at this point in the history
  2. [refactor] The this.request now has a much simpler API structure.

    [minor] Using strict mode in the module now, it caught some small pitfalls
    [minor] Small optimazations to the createClient, no pointless event listeners are added
    [minor] Removed pointless require statements and made the code style more uniform.
    
    The reason for this refactor is that we need to support different remoteApi's for the
    applications as they can be hosted in different data centers.
    3rd-Eden committed Jan 7, 2013
    Copy the full SHA
    83d4b39 View commit details
    Browse the repository at this point in the history
  3. [datacenter] Make the request method datacenter aware

    [minor] Removed the `res.statusCode` code smell
    
    Applications that are hosted in different datacenters need to be called at their
    correct endpoint. The cloud details are inside of the app documents so we need to fetch
    both the endpoint resource and the app document before we know which datacenter we
    need to hit for the given change.
    
    The statusCode was introduced in commit 9cea327 but
    Avian has no memory of why he did it. So i'm removing it to prevent possible breakage
    when you expect that the result is always an object.
    3rd-Eden committed Jan 7, 2013
    Copy the full SHA
    9a0558d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    92aef4e View commit details
    Browse the repository at this point in the history