[fix] replicate node core behavior and throw an error if the user doe…

…s not add their own error listener
http-party · Jan 28, 2014 · daad470 · daad470 · 3rd-Eden · Jan 28, 2014
1 parent b606735
commit daad470
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/lib/http-proxy/index.js b/lib/http-proxy/index.js
@@ -68,7 +68,7 @@ function createRightProxy(type) {
         if (typeof options[e] === 'string')
           options[e] = parse_url(options[e]);
       });
-       
+
       if(typeof this.emit === 'undefined' && !cbl) { throw new Error("You need to pass a callback to handle errors") }
 
       for(var i=0; i < passes.length; i++) {
@@ -104,13 +104,22 @@ function ProxyServer(options) {
     return ws[pass];
   });
 
-  this.on('error', function(err) {
-    console.log(err);
-  });
+  this.on('error', this.onError.bind(this));
+
 }
 
 require('util').inherits(ProxyServer, EE3);
 
+ProxyServer.prototype.onError = function (err) {
+  //
+  // Remark: Replicate node core behavior using EE3
+  // so we force people to handle their own errors
+  //
+  if(this.listeners('error').length === 1) {
+    throw err;
+  }
+};
+
 ProxyServer.prototype.listen = function(port, hostname) {
   var self    = this,
       closure = function(req, res) { self.web(req, res); };