Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change git clone command to use double quotes instead of single quotes #396

Merged
merged 2 commits into from Jul 14, 2012

Conversation

l4u
Copy link
Contributor

@l4u l4u commented Jul 13, 2012

Single quote prevents variable interpolation.
For example, when the source includes variables such as $HOME, git clone will fail.

If this is merged, the fix should be applied to other downloaders as well.

@travisbot
Copy link

This pull request passes (merged 573cc3f into d4f319b).

@alloy
Copy link
Member

alloy commented Jul 13, 2012

Can you tell me your specific use case? If it’s only about the home dir, could you use ~/ instead of $HOME?

@l4u
Copy link
Contributor Author

l4u commented Jul 13, 2012

I am putting in-house libraries in my home dir.

git clone '~/ProjectName' doesn't work too. (I'm using zsh.)
git clone "~/ProjectName" works

same applies to $HOME

@alloy
Copy link
Member

alloy commented Jul 13, 2012

I’m trying to think what kind of negative implications this could have, but for now I think it would be ok.

@irrationalfab Do you have any thoughts?

@fabiopelosin
Copy link
Member

@irrationalfab Do you have any thoughts?

I don't see any negative implication either.

@alloy
Copy link
Member

alloy commented Jul 13, 2012

Ok.

@l4u Can you update this for all downloaders?

@travisbot
Copy link

This pull request passes (merged 07773d2 into d4f319b).

@alloy
Copy link
Member

alloy commented Jul 14, 2012

Thanks!

alloy added a commit that referenced this pull request Jul 14, 2012
Change git clone command to use double quotes instead of single quotes
@alloy alloy merged commit 0597bf7 into CocoaPods:master Jul 14, 2012
alloy added a commit that referenced this pull request Oct 25, 2014
Change git clone command to use double quotes instead of single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants