Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
[fix] Start the app if it isn't started when Apps.datacenter is called.
- Loading branch information
Showing
1 changed file
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c2ed31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a test
7c2ed31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels wrong in several ways, but it fixes things for now. We will revert this in the next week or two once the upstream fix lands in the API server.
7c2ed31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indexzero This was definitely a quick fix, because there was a user having problems with scaling. Rerouting the scaling in jitsu where I did caused it to throw an error when the app is freshly created because it hasn't been started yet. @AvianFlu and I agreed that it was better to start it than throw the error message about it not being started, at least for the time being. Not sure exactly what caused jitsu to break yet.
@3rd-Eden There actually aren't any tests at all for cloud in this repo. I'll work on those once we get this whole situation straightened out with it and get this change reverted. If we can just figure out what caused the break in the first place, we can go ahead and revert these changes.
7c2ed31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Southern What's the "break"? Is there an issue somewhere I can look at?
7c2ed31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@indexzero @AvianFlu and I weren't able to figure out what broke it, so I ended up having to throw in this quick fix. I didn't see any changes in the recent jitsu commits that looked like they would break that functionality, so I'm not exactly sure what's going on with it.