Members search #671
Merged
Members search #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: emanuele <emanuele45@gmail.com>
Signed-off-by: emanuele <emanuele45@gmail.com>
… to a todo comment in the code about email_address) Signed-off-by: emanuele <emanuele45@gmail.com>
|
I think contextual search will help to use the space in a user-friendly manner. Thanks :) Looks good to me. Merge? |
|
If also the latest commit is fine (note: that's another place createList may be used), I think it can be merged. |
Right. It'd be nice to try to rewrite this with createList. And get away with some code 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Feature Cat likes it I'm sending what I did. :P
The PR also contains some change to the way the table of the memberlist is created... It is related to the comment
// @TODO maybe find something nicer?