Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 158cd0a3e447
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f43a481e5af0
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 26, 2014

  1. Make String#to_proc return value allow arguments. 

    Among other things, this allows binary operators to work:

  (:+).to_proc.call(1, 2)  # => 3

This is most commonly encountered as a result of:

    [1, 2].reduce(&:+)

(Note the ampersand.)
    @mieko
    mieko committed Mar 26, 2014
    Copy the full SHA
    bca0922 View commit details

Commits on Apr 7, 2014

  1. Merge pull request #515 from mieko/master 

    Make String#to_proc return value allow arguments.
    @adambeynon
    adambeynon committed Apr 7, 2014
    Copy the full SHA
    f43a481 View commit details
Showing with 3 additions and 8 deletions.
  1. +3 −8 opal/corelib/string.rb
11 changes: 3 additions & 8 deletions opal/corelib/string.rb
View file
Original file line number Diff line number Diff line change
@@ -880,14 +880,9 @@ def to_i(base = 10)
end

def to_proc
%x{
var name = '$' + self;
return function(arg) {
var meth = arg[name];
return meth ? meth.call(arg) : arg.$method_missing(name);
};
}
proc do |recv, *args|
recv.send(self, *args)
end
end

def to_s