Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for auth-common #235

Closed
wants to merge 3 commits into from

Conversation

bbpennel
Copy link
Collaborator

Created unit tests for FedoraUserSecurityContext and ServletContainerAuthenticationProvider.

import org.modeshape.jcr.security.AuthenticationProvider;
import org.modeshape.jcr.value.Path;

public class ServletContainerAuthenticationProviderTest {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "author" annotation (and Date):
/**

  • @author Ben Pennell
  •     Date: Feb 11, 2014
    
    */

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something your IDE can do automatically for you. If you use Eclipse, ping me in IRC if you want help.

@ajs6f
Copy link
Contributor

ajs6f commented Feb 12, 2014

NIce stuff, @bbpennel! Very clear and readable.

@awoods
Copy link

awoods commented Feb 13, 2014

Resolved with: 5650d03

@awoods awoods closed this Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants